Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update codeowners #458

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Aug 1, 2024

Fixes #457.

Tagging specifically @bhess @thb-sb @feventura @iyanmv whether you're OK with these updates highlighting your contributions and codifying them explicitly in CODEOWNERS. The goal of this is to automatically request the right people in the future to help reviewing PRs on those files.

Any and all updates (preferably, your willingness to be listed in more sections of the CODEOWNER file -- but also fewer) very welcome.

@feventura, please let me know if the association of yourself is too broad (all sig algs) -- I'd then try harder to factor out the composite sig code as I did for the hybrid KEM code of @bhess.

@feventura @iyanmv it seems you're lacking write access to the repo: If you'd state you're OK with these changes, I'll try to convince the LF admins to change this suitably.

baentsch added 4 commits July 30, 2024 08:33
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
@baentsch baentsch requested review from bhess, dstebila, SWilson4 and a user August 1, 2024 04:37
@iyanmv
Copy link
Member

iyanmv commented Aug 1, 2024

@baentsch at least for me, don't waste time/effort to ask for write access ;) It was a one time small contribution. If in the future I do more, we can revisit that option.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thank you :)

@SWilson4
Copy link
Member

SWilson4 commented Aug 1, 2024

@baentsch If you would like access added for @feventura and @iyanmv, I can tack the config changes onto this PR, and then you can approve and merge.

@feventura
Copy link
Contributor

@baentsch I read a lot the code on all sigs, but I don't know the non-composite sigs well enough to answer questions for them.
That saying I think its too broad, but I don't mind answering "I can only answer questions for composite sigs" when I'm tagged with something while me, or someone else, work on the factoring out composite, like it is for hybrid KEM.

@baentsch
Copy link
Member Author

baentsch commented Aug 1, 2024

@baentsch If you would like access added for @feventura and @iyanmv, I can tack the config changes onto this PR, and then you can approve and merge.

That would be great, @SWilson4 !

@baentsch
Copy link
Member Author

baentsch commented Aug 1, 2024

@baentsch I read a lot the code on all sigs, but I don't know the non-composite sigs well enough to answer questions for them.
That saying I think its too broad, but I don't mind answering "I can only answer questions for composite sigs" when I'm tagged with something while me, or someone else, work on the factoring out composite, like it is for hybrid KEM.

Thanks, @feventura . We'd then merge this as-is and create a separate issue to factor out Composites to make this better. I'd be grateful if you could take a first swing at implementing that, if you'd have time. If not, I'll try to do sth sensible (I hope).

@SWilson4
Copy link
Member

SWilson4 commented Aug 1, 2024

@baentsch If you would like access added for @feventura and @iyanmv, I can tack the config changes onto this PR, and then you can approve and merge.

That would be great, @SWilson4 !

All done, review and merge (if satisfactory) as you see appropriate!

@baentsch baentsch merged commit 8a2b5bc into open-quantum-safe:main Aug 3, 2024
29 checks passed
@baentsch baentsch deleted the mb-designations branch August 3, 2024 05:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve project maintainability
5 participants