Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix various warnings. #480

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Fix various warnings. #480

merged 2 commits into from
Aug 18, 2024

Conversation

ashman-p
Copy link
Contributor

Fixes #467.

@ashman-p ashman-p marked this pull request as ready for review August 13, 2024 21:21
@ashman-p ashman-p requested a review from a user August 13, 2024 21:21
@ashman-p
Fix various warnings.
3deca04 
Signed-off-by: Norman Ashley <nashley@cisco.com>
@ashman-p
Fix coding style
d19ee3e 
Signed-off-by: Norman Ashley <nashley@cisco.com>
@ashman-p ashman-p force-pushed the na_fix_mac_warnings branch from f781668 to d19ee3e Compare August 15, 2024 06:10
@ashman-p ashman-p marked this pull request as draft August 15, 2024 15:00
@ashman-p ashman-p marked this pull request as ready for review August 15, 2024 15:01
@ashman-p
Copy link
Contributor Author

@baentsch , @feventura , @thb-sb, please take a look at this PR when you are able. Thanks.

baentsch
baentsch approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, @ashman-p !

@baentsch baentsch merged commit e547338 into open-quantum-safe:main Aug 18, 2024
26 checks passed
@ashman-p ashman-p deleted the na_fix_mac_warnings branch August 28, 2024 00:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@feventura feventura Awaiting requested review from feventura feventura is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various warnings building OQS Provider on Mac
2 participants
@ashman-p @baentsch