Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed Build/Runtime errors + Dockerized #5

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cardboardcode
Copy link

Purpose of Pull Request

This pull request targets the following faulty python code statements causing build/runtime errors when attempting to build door_adapter_template ROS 2 package.

Fixed bug 🐛

Build Error: faulty string literal - Bug 1
Runtime Error: faulty import of DoorClientAPI class - Bug 2
Build Error: Missing maintainer email - Bug 3

Fix applied 🐛 🤛

  • Corrected the python statements mentioned above. Verified it via a successful build via ROS 2 colcon build as well as observed no further runtime error when running.
  • Standardised door_adapter_template throughout door_adapter_template ROS 2 package, replacing instances of door_adapter

New feature implementation ➕

Dockerised door_adapter_template to ensure ease-of-setup for future developers as well as provided up-to-date instructions on how to use it properly.

Implemented features

  • Added root Dockerfile based on ROS 2 Humble.
  • Added Docker Build and Docker Run instructions in root README.md

Implementation description

Please run the commands below to verify that door_adapter_template faces no build errors when compiling with colcon build and no runtime errors when running:

cd $HOME
git clone https://github.com/KABAM-Robotics/door_adapter_template --branch bugfix/fix_package_compilation_error --depth 1 --single-branch
cd door_adapter_template
docker build -t door_adapter_template:humble .

The docker image door_adapter_template:humble should build with no errors.

cd $HOME/door_adapter_template
docker run -it --rm \
    --name door_adapter_template_c \
    --network host \
    -v /dev/shm:/dev/shm \
    -v ./door_adapter_template/config.yaml:/door_adapter_template_ws/src/door_adapter_template/config.yaml \
door_adapter_template:humble /bin/bash -c \
"source /ros_entrypoint.sh && ros2 run door_adapter_template door_adapter --config_file /door_adapter_template_ws/src/door_adapter_template/config.yaml"

Signed-off-by: gary.bey <gary.bey@kabam.ai>
…age to door_adapter_template, instead of door_adapter.

Signed-off-by: gary.bey <gary.bey@kabam.ai>
Signed-off-by: gary.bey <gary.bey@kabam.ai>
Signed-off-by: gary.bey <gary.bey@kabam.ai>
…ase-of-set-up.

Signed-off-by: gary.bey <gary.bey@kabam.ai>
Signed-off-by: gary.bey <gary.bey@kabam.ai>
@cardboardcode cardboardcode force-pushed the bugfix/fix_package_compilation_error branch from 916009d to 6d6c013 Compare October 18, 2024 06:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant