Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Perform action #15

Merged
merged 11 commits into from
Nov 21, 2022
Merged

Perform action #15

merged 11 commits into from
Nov 21, 2022

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Aug 30, 2022

This adds support for perform_action, targeting specific mission names that have been predefined in the MiR dashboard, and can be listed in the config file to be called as a perform_action task.

… fixes in accessing dict

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ane distance in example config

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments about things that I think should be changed, but also some suggestions that are just meant to be notes for potential future improvements.

fleet_adapter_mir/MiRCommandHandle.py Outdated Show resolved Hide resolved
fleet_adapter_mir/MiRCommandHandle.py Outdated Show resolved Hide resolved
fleet_adapter_mir/MiRCommandHandle.py Outdated Show resolved Hide resolved
fleet_adapter_mir/MiRCommandHandle.py Outdated Show resolved Hide resolved
configs/mir_config.yaml Outdated Show resolved Hide resolved
Base automatically changed from various-fixes to main September 7, 2022 06:38
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
* First implementation of calling predefined variable move mission

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* added variable_move_mission field in example config, fixed mir_config

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Add assert that start sets are not empty, and fix API usage for start.lane

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed unused create move missions, fix use before declare

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Docking using pre-defined mission, adding to example config

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed variable_move_mission to more descriptive rmf_move_mission, updated all use cases as well, added additional documentation

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@aaronchongth aaronchongth merged commit 92c457d into main Nov 21, 2022
@aaronchongth aaronchongth deleted the perform-action branch November 21, 2022 05:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants