-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Setting camera target to most negative number to handle arbitrary large maps #993
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this affects, but if we know the size of the map, then could we calculate this dynamically? If not then is there value to make this an app-config?
… creation Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
This changes the 3D position that the camera points towards, raising it to a large negative number implies that the camera will almost always be pointing down vertically, no matter where the camera is moved to in 3D space. This helps mimic an orthogonal view. Although this value falls under the category of bigger-is-better, there's no harm in using the scene size to calculate it dynamically I guess. I've also refactored the camera controls a little to reduce repeated construction of cameras and its controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like there is no harm in having a smaller value? If so then let's revert the dynamic calculation change.
As explained the purpose of these changes in DM |
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
What's new
Self-checks