Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

method call validator should handle .required #146

Closed
shanejonas opened this issue Jun 14, 2019 · 1 comment · Fixed by #147
Closed

method call validator should handle .required #146

shanejonas opened this issue Jun 14, 2019 · 1 comment · Fixed by #147
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Member

Describe the bug
method call validator should handle .required

To Reproduce
generate new client with optional parameters with .required

  const balance = await erpc.eth_getBalance("0x7d0791614d848cac65223ecf622c9fecbff84bc7");

image

and the openrpc.json:
image
@shanejonas shanejonas added the bug Something isn't working label Jun 14, 2019
shanejonas added a commit that referenced this issue Jun 14, 2019
@shanejonas
fix: validate optional params
4feb647 
fixes #146
@shanejonas shanejonas mentioned this issue Jun 14, 2019
Merged
BelfordZ added a commit that referenced this issue Jun 14, 2019
@BelfordZ
chore(release): 1.10.3 [skip ci]
992c1fb 
## [1.10.3](1.10.2...1.10.3) (2019-06-14)

### Bug Fixes

* circle semantic release deps only ([257b585](257b585))
* remove semantic release deps ([27ff23c](27ff23c))
* update pacakge lock ([1699ee8](1699ee8))
* validate optional params ([4feb647](4feb647)), closes [#146](#146)
@BelfordZ
Copy link
Member

🎉 This issue has been resolved in version 1.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate optional params open-rpc/schema-utils-js
2 participants
@shanejonas @BelfordZ