Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/remove lodash #414

Merged
merged 6 commits into from
Aug 10, 2020
Merged

Fix/remove lodash #414

merged 6 commits into from
Aug 10, 2020

Conversation

mattbford
Copy link
Contributor

@mattbford mattbford commented Jul 30, 2020

fixes #406
fixes #420

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #414 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   99.60%   99.66%   +0.06%     
==========================================
  Files          11       12       +1     
  Lines         253      299      +46     
  Branches       60       73      +13     
==========================================
+ Hits          252      298      +46     
  Partials        1        1              
Impacted Files Coverage Δ
src/generate-method-id.ts 100.00% <100.00%> (ø)
src/helper-functions.ts 100.00% <100.00%> (ø)
src/method-call-validator/method-call-validator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e3cd3...093158b. Read the comment docs.

@mattbford mattbford requested review from BelfordZ and shanejonas July 31, 2020 23:27
@mattbford mattbford self-assigned this Jul 31, 2020
@mattbford mattbford added the enhancement New feature or request label Jul 31, 2020
* @param doc2 {OpenrpcDocument}
* @returns {boolean}
*/
export const rpcDocIsEqual = (doc1: any, doc2: any) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's only included in the test, you can put it in a .test. file to have it not included in the build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattbford mattbford merged commit 1683ba9 into master Aug 10, 2020
@mattbford mattbford deleted the fix/remove-lodash branch August 10, 2020 20:53
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an editor config Remove lodash dep
4 participants