Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regular updates to B5500, I7000, PDP10 #375

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

rcornwell
Copy link
Member

No description provided.

rcornwell added 3 commits May 19, 2024 14:14
         Card reader handle EOF correctly.
         Line printer proper handling of paging.
         Magtape clean up debug message.
         Update 7010, 7070, 7080 for EOF handling.
       Fix divide of 0 on KS10 processor.
       Fix write access for auxiliary processor memory.
       Updated support new PIDP10 panel.
       Allow eight Unibux ports on the TEN device.
       Added GE DATANET-760 device to PDP6
       Removed USER mode restriction for idle detection.
       Added Data Disc 6600 Television Display System.
@markpizz
Copy link
Contributor

The "KA10: Fix divide error on KS10, add in some devices." commit adds a copy of the pdp11_ddcmp.h file from the PDP11 directory.

Historically, simulators in the PDP10 and the VAX directories, specifically reference various files that exist in the PDP11 directory directly without having copies of those files in the local simulator directory. It would seem best that the pdp11_ddcmp.h file should also be referenced rather than copied...

@rcornwell
Copy link
Member Author

It has been that way for years now. Also I believe I had to make some changes to it.

@markpizz
Copy link
Contributor

The commit I mentioned newly adds the PDP10/pdp11_ddcmp.h file. That commit is the most recent commit in this PR, so it hardly has been years.

If changes/additions to the original file are actually needed, they should be made to the original file in the original location.

@pkoning2
Copy link
Member

pdp11_ddcmp.h is newly added by this PR, and it's identical to the original. So I agree with Mark: please use the original directly. If at some point it has to diverge, then that could either be done with conditional compiles (as is done for some other files) or by making a copy then.

@rcornwell
Copy link
Member Author

Done.

@pkoning2 pkoning2 merged commit 4396394 into open-simh:master May 21, 2024
17 of 18 checks passed
@markpizz
Copy link
Contributor

1>..\PDP10\kx10_tym.c(549) : warning C4244: '=' : conversion from 'uint64' to 'int', possible loss of data

1>..\PDP10\ka10_dd.c(389) : error C2220: warning treated as error - no 'object' file generated
1>..\PDP10\ka10_dd.c(389) : warning C4101: 'j' : unreferenced local variable
1>..\PDP10\ka10_dd.c(519) : warning C4244: '=' : conversion from 'uint64' to 'int32', possible loss of data
1>..\PDP10\ka10_dd.c(544) : warning C4018: '>=' : signed/unsigned mismatch
1>..\PDP10\ka10_dd.c(657) : warning C4244: '=' : conversion from 't_value' to 'int', possible loss of data
1>..\PDP10\ka10_dd.c(729) : warning C4244: '=' : conversion from 'uint64' to 'uint32', possible loss of data

kx10_cpu.c has tabs rather than tabs expanded to spaces as is the simh project standard

ka10_dd_font.h and kx10_ddc.c have LF line endings instead of the simh project standard of CRLF

@rcornwell
Copy link
Member Author

These two files were done by @larsbrinkhoff He needs to fix them.
As to kx10_cpu.c I will verify there are no tabs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants