Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"getDeps_UNSTABLE()" to "Snapshot.getInfo_UNSTABLE().deps" #140

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

samihamine
Copy link
Contributor

@samihamine samihamine commented May 7, 2021

Snapshot.getDeps_UNSTABLE has been removed in recoil 0.2.0. This API changed to Snapshot.getInfo_UNSTABLE().deps. Recoilize needs to be updated here to be compatible with the latest recoil 0.2.0 release.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Snapshot.getDeps_UNSTABLE has been removed in recoil 0.2.0. This API changed to Snapshot.getInfo_UNSTABLE().deps. Recoilize needs to be updated here to be compatible with the latest recoil 0.2.0 release.

Approach

change to "Snapshot.getInfo_UNSTABLE().deps"

Resources

Docs from recoil js :
https://recoiljs.org/docs/api-reference/core/Snapshot/

Snapshot.getDeps_UNSTABLE has been removed in recoil 0.2.0. This API changed to Snapshot.getInfo_UNSTABLE().deps. Recoilize needs to be updated here to be compatible with the latest recoil 0.2.0 release.
@vickmeng
Copy link

vickmeng commented Jun 4, 2021

hello, I hope to know when to push new version to fix this problem?

@johannbuscail
Copy link

Why isn't someone reviewing this PR ?! It's been a month.
@razananisathar @nbargers

@johannbuscail
Copy link

I'm kind of sad no one takes care of this library...

@davidenke
Copy link

This is annoying. For the time being: patch-package...

@johannbuscail
Copy link

Can we get a message from the maintainers to know if they're still alive and why isn't this merged ???
@razananisathar @nbargers

@vincentferniotoclock
Copy link

This should do the trick for backward compatibility, I tried to push it to create new PR without success

 const getSnapshotDeps = (node) => snapshot.getDeps_UNSTABLE ? snapshot.getDeps_UNSTABLE(node) : snapshot.getInfo_UNSTABLE(node).deps;

  nodes.forEach(node => {
    const snapshotDeps = [...getSnapshotDeps(node)];
    nodeDeps[node.key] = snapshotDeps.map(dep => dep.key);
  });

@samihamine
Copy link
Contributor Author

Thanks @vincentferniotoclock for the improvement 💐

@Taylor123
Copy link

Is this tool still being maintained?

@metacoding
Copy link

I think this is no longer maintained

Copy link
Contributor

@joey-ma joey-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM

@joey-ma
Copy link
Contributor

joey-ma commented Jan 20, 2022

From the Recoilize team, thank you all so much for your interest. Here’s the long overdue update for those of you who brought up concerns of maintenance.

As an open source product developed under OSLabs, the current team of contributors have recently fixed some bugs, improved some UI/UX consistencies, and added new features. As we are also excited about the prospect of Recoil.js becoming mainstream, thereby our decision to become contributors of Team Recoilize, we will be happy to maintain Recoilize from time to time. However, as former contributors may have moved on to other projects / stages in their career, we may one day do the same. Nonetheless, we truly appreciate the community’s support, participation, and constructive feedback and contribution.

Please check out our latest release of Recoilize (3.0), which will be launching by the end of day today!

@joey-ma joey-ma merged commit fd17d21 into open-source-labs:staging Jan 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.