-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
"getDeps_UNSTABLE()" to "Snapshot.getInfo_UNSTABLE().deps" #140
Conversation
Snapshot.getDeps_UNSTABLE has been removed in recoil 0.2.0. This API changed to Snapshot.getInfo_UNSTABLE().deps. Recoilize needs to be updated here to be compatible with the latest recoil 0.2.0 release.
hello, I hope to know when to push new version to fix this problem? |
Why isn't someone reviewing this PR ?! It's been a month. |
I'm kind of sad no one takes care of this library... |
This is annoying. For the time being: |
Can we get a message from the maintainers to know if they're still alive and why isn't this merged ??? |
This should do the trick for backward compatibility, I tried to push it to create new PR without success const getSnapshotDeps = (node) => snapshot.getDeps_UNSTABLE ? snapshot.getDeps_UNSTABLE(node) : snapshot.getInfo_UNSTABLE(node).deps;
nodes.forEach(node => {
const snapshotDeps = [...getSnapshotDeps(node)];
nodeDeps[node.key] = snapshotDeps.map(dep => dep.key);
}); |
Thanks @vincentferniotoclock for the improvement 💐 |
Is this tool still being maintained? |
I think this is no longer maintained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM
From the Recoilize team, thank you all so much for your interest. Here’s the long overdue update for those of you who brought up concerns of maintenance. As an open source product developed under OSLabs, the current team of contributors have recently fixed some bugs, improved some UI/UX consistencies, and added new features. As we are also excited about the prospect of Recoil.js becoming mainstream, thereby our decision to become contributors of Team Recoilize, we will be happy to maintain Recoilize from time to time. However, as former contributors may have moved on to other projects / stages in their career, we may one day do the same. Nonetheless, we truly appreciate the community’s support, participation, and constructive feedback and contribution. Please check out our latest release of Recoilize (3.0), which will be launching by the end of day today! |
Snapshot.getDeps_UNSTABLE has been removed in recoil 0.2.0. This API changed to Snapshot.getInfo_UNSTABLE().deps. Recoilize needs to be updated here to be compatible with the latest recoil 0.2.0 release.
Types of changes
Purpose
Snapshot.getDeps_UNSTABLE has been removed in recoil 0.2.0. This API changed to Snapshot.getInfo_UNSTABLE().deps. Recoilize needs to be updated here to be compatible with the latest recoil 0.2.0 release.
Approach
change to "Snapshot.getInfo_UNSTABLE().deps"
Resources
Docs from recoil js :
https://recoiljs.org/docs/api-reference/core/Snapshot/