Skip to content

Don't use build dir build interfaces #1419

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

Scotty1701
Copy link
Contributor

Effectively reverts a change from #933 which added a new build interface to include a version.h file. This version.h was deleted in #997 but the new build interface remained. This change allows jsoncpp to be included in CMake projects easily with FetchContent (would previously fail as a non-existent path would be added to the target's INTERFACE_INCLUDE_DIRECTORIES).

Do not export a location in the build directory as a build interface.
This location is not created until the build step is run and can
interfere with the CMake configuration step if including in another
project.
@baylesj baylesj merged commit 89e2973 into open-source-parsers:master Sep 10, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants