Skip to content

Opportunistically take advantage of C++20 move-in/out-of stringstream #1457

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2024
Merged

Opportunistically take advantage of C++20 move-in/out-of stringstream #1457

merged 4 commits into from
Sep 10, 2024

Conversation

beevvy
Copy link
Contributor

@beevvy beevvy commented Jan 6, 2023

No description provided.

@beevvy
Copy link
Contributor Author

beevvy commented Jan 11, 2023

Pushed a similar change for json_reader.cpp.

BTW, I realize it won't have any effect when compiling with -std=c++11, which is the default, but it will for projects using the amalgamation, for example.

@beevvy beevvy changed the title Opportunistically take advantage of C++20 move-out-of stringstream Opportunistically take advantage of C++20 move-in/out-of stringstream Jan 11, 2023
@baylesj baylesj merged commit 48d2e10 into open-source-parsers:master Sep 10, 2024
10 checks passed
@chenrui333 chenrui333 mentioned this pull request Sep 13, 2024
Merged
@beevvy beevvy deleted the write-string branch November 8, 2024 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BillyDonahue BillyDonahue BillyDonahue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beevvy @BillyDonahue @baylesj