Skip to content

Fix bug 886 #869

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Fix bug 886 #869

merged 2 commits into from
Jan 18, 2019

Conversation

hjmjohnson
Copy link
Contributor

No description provided.

@hjmjohnson hjmjohnson self-assigned this Jan 18, 2019
Older versions of cmake, according to documentation:
https://cmake.org/cmake/help/v3.5/command/if.html , do not know
VERSION_LESS_EQUAL, just VERSION_LESS.

This leads to errors:

CMake Error at somewhere/jsoncpp/CMakeLists.txt:18 (if):
  if given arguments:

    "3.5.1" "VERSION_LESS_EQUAL" "3.13.1"

  Unknown arguments specified

Resolves: #866
@hjmjohnson hjmjohnson added bug build or testing cmake, meson, continuous integration, or testing related labels Jan 18, 2019
Copy link
Contributor

@BillyDonahue BillyDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@hjmjohnson hjmjohnson merged commit 2c25759 into master Jan 18, 2019
@baylesj baylesj deleted the fix-bug-886 branch June 24, 2019 21:08
@baylesj baylesj restored the fix-bug-886 branch June 24, 2019 21:08
@baylesj baylesj deleted the fix-bug-886 branch June 24, 2019 21:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug build or testing cmake, meson, continuous integration, or testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants