Add client context propagation #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Jan 26, 2024
| } | ||
| } else { | ||
| r.logger.Debugf(ctx, "Ignoring Opamp, agent does not have AcceptsOpAMPConnectionSettings capability") | ||
| } | ||
| } | ||
|
|
||
| func (r *receivedProcessor) processErrorResponse(ctx context.Context, body *protobufs.ServerErrorResponse) { | ||
| // TODO: implement this. | ||
| r.logger.Errorf(ctx, "received an error from server: %s", body.ErrorMessage) | ||
| if body != nil { |
There was a problem hiding this comment.
This never called the OnError method when it should have.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 72.86% 72.92% +0.06%
==========================================
Files 25 25
Lines 2038 2039 +1
==========================================
+ Hits 1485 1487 +2
+ Misses 444 443 -1
Partials 109 109 ☔ View full report in Codecov by Sentry. |
tigrannajaryan
approved these changes
Jan 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #237 and #247, adding context propagation for client methods.
This involves a breaking change for the client interfaces