feat: Add implementation of new AvailableComponents message #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 77.81% 78.29% +0.47%
==========================================
Files 25 25
Lines 2321 2386 +65
==========================================
+ Hits 1806 1868 +62
- Misses 408 410 +2
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
|
Comfortable moving this into Ready for Review - have successfully manually tested this implementation end-to-end with a custom build of the OpAMP Supervisor and OpAMP extension in open-telemetry/opentelemetry-collector-contrib. |
This was referenced Jan 15, 2025
This reverts commit 9e2acf3.
evan-bradley
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 28, 2025
…#37250) #### Description This feature implements support for the new AvailableComponents message in opamp-go for the OpAMP supervisor: open-telemetry/opamp-go#340 ~~Since the AvailableComponents message has not yet been released, this PR contains replace directives for testing purposes. This PR will not be merged until opamp-go has been released with the new AvailableComponents message implementation, at which point the replace directives will be removed.~~ opamp-go v0.19.0 has been released. This PR is one of two that make up #37248 #### Link to tracking issue Fixes #37247 #### Testing Updated unit tests Manual end-to-end testing using the OpAMP extension and an external OpAMP server. #### Documentation Updated README --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the specification added to opamp-spec in open-telemetry/opamp-spec#201