-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add client-initiated certificate request flow (CSR) #162
Add client-initiated certificate request flow (CSR) #162
Conversation
874f0f0
to
43bbc69
Compare
d014902
to
7488bc6
Compare
Looks good. |
@open-telemetry/specs-approvers @srikanthccv please review this proposal. I also made a draft implementation in Go to demonstrate how the CSR flow works: open-telemetry/opamp-go#192 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will take a look at draft implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the flow looks good to me, I only have wordsmithing suggestions.
Thanks @evan-bradley |
@andykellr I wonder what you think about this, it would be great if you could take a look. |
Resolves open-telemetry#13 Uses [Development] label as the indication of the least mature level proposed in this upcoming OTEP: open-telemetry/oteps#232
Resolves open-telemetry#13 Uses [Development] label as the indication of the least mature level proposed in this upcoming OTEP: open-telemetry/oteps#232
82f4438
to
7b3fff9
Compare
- Implemented spec change open-telemetry/opamp-spec#162 - Added ability for the client to request connection settings. - Added CSR flow example to demonstrate the new capability.
- Implemented spec change open-telemetry/opamp-spec#162 - Added ability for the client to request connection settings. - Added CSR flow example to demonstrate the new capability.
- Implemented spec change open-telemetry/opamp-spec#162 - Added ability for the client to request connection settings. - Added CSR flow example to demonstrate the new capability.
- Implemented spec change open-telemetry/opamp-spec#162 - Added ability for the client to request connection settings. - Added CSR flow example to demonstrate the new capability.
- Implemented spec change open-telemetry/opamp-spec#162 - Added ability for the client to request connection settings. - Added CSR flow example to demonstrate the new capability.
- Implemented spec change open-telemetry/opamp-spec#162 - Added ability for the client to request connection settings. - Added CSR flow example to demonstrate the new capability.
Resolves #13
Uses [Development] label as the indication of the least mature level proposed in this upcoming OTEP:
open-telemetry/oteps#232
[UPDATE]: I added a draft implementation in Go to demonstrate how the CSR flow works: open-telemetry/opamp-go#192