Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

address lint issues: Implicit Memory Aliasing #28584

Closed
codeboten opened this issue Oct 24, 2023 · 5 comments
Closed

address lint issues: Implicit Memory Aliasing #28584

codeboten opened this issue Oct 24, 2023 · 5 comments
Assignees
@etiennep
Labels
Contribfest good first issue Good for newcomers help wanted Extra attention is needed receiver/kubeletstats

Comments

@codeboten
Copy link
Contributor

Component(s)

receiver/kubeletstats

Describe the issue you're reporting

This issue is to remove the // nolint G601 comments in receiver/kubeletstatsreceiver/internal/kubelet/metadata.go
@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 24, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten
Copy link
Contributor Author

This comment is added in #28572

@TylerHelmuth TylerHelmuth added Contribfest and removed help wanted Extra attention is needed good first issue Good for newcomers labels Oct 26, 2023
@github-actions github-actions bot mentioned this issue Oct 31, 2023
Closed
@etiennep
Copy link
Contributor

I'd like to work on this.

@TylerHelmuth
Copy link
Member

@etiennep it's yours!

@etiennep etiennep mentioned this issue Nov 11, 2023
Merged
codeboten pushed a commit that referenced this issue Nov 14, 2023
@etiennep @TylerHelmuth
[receiver/kubeletstatsreceiver] address lint issues: Implicit Memory …
30a5f14 
…Aliasing (#29113)

This PR fixes an implicit memory aliasing lint issue in
the kubeletstatsreceiver

* fixed code
* removed linting exception

#28584

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@etiennep @TylerHelmuth @RoryCrispin
[receiver/kubeletstatsreceiver] address lint issues: Implicit Memory …
5f5844b 
…Aliasing (open-telemetry#29113)

This PR fixes an implicit memory aliasing lint issue in
the kubeletstatsreceiver

* fixed code
* removed linting exception

open-telemetry#28584

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 13, 2023
@atoulme
Copy link
Contributor

atoulme commented Dec 13, 2023

Closing as complete.

@atoulme atoulme closed this as completed Dec 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@etiennep etiennep

Labels
Contribfest good first issue Good for newcomers help wanted Extra attention is needed receiver/kubeletstats
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@atoulme @codeboten @etiennep @TylerHelmuth