Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[processor/resourcedetection] Add host.mac to system detector #29587

Closed
Tracked by #22045
mx-psi opened this issue Nov 30, 2023 · 0 comments · Fixed by #29588
Closed
Tracked by #22045

[processor/resourcedetection] Add host.mac to system detector #29587

mx-psi opened this issue Nov 30, 2023 · 0 comments · Fixed by #29588

Comments

@mx-psi
Copy link
Member

mx-psi commented Nov 30, 2023

No description provided.

This was referenced Nov 30, 2023
Closed
Merged
@github-actions github-actions bot mentioned this issue Dec 5, 2023
Closed
mx-psi added a commit that referenced this issue Dec 7, 2023
@mx-psi @crobert-1
[processor/resourcedetection] Add host.mac to system detector (#29588)
cdfaa45 
**Description:**

Adds support for `host.mac` detection to the `system` detector on the
resource detection processor.

This convention is defined in the specification [on the host
document](https://github.com/open-telemetry/semantic-conventions/blob/v1.23.1/docs/resource/host.md).

**Link to tracking Issue:** Fixes #29587 and therefore fixes #22045

**Testing:** 

Unit tests; manually Tested on my laptop with the following
configuration:

```
receivers:
  hostmetrics:
    collection_interval: 10s
    scrapers:
      load:

processors:
  resourcedetection:
    detectors: ["system"]
    system:
      resource_attributes:
        host.mac:
          enabled: true

exporters:
  debug:
    verbosity: detailed

service:
  pipelines:
    metrics:
      receivers: [hostmetrics]
      processors: [resourcedetection]
      exporters: [debug]
```

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
jayasai470 pushed a commit to jayasai470/opentelemetry-collector-contrib that referenced this issue Dec 8, 2023
@mx-psi @crobert-1 @jayasai470
[processor/resourcedetection] Add host.mac to system detector (open-t…
4a89d29 
…elemetry#29588)

**Description:**

Adds support for `host.mac` detection to the `system` detector on the
resource detection processor.

This convention is defined in the specification [on the host
document](https://github.com/open-telemetry/semantic-conventions/blob/v1.23.1/docs/resource/host.md).

**Link to tracking Issue:** Fixes open-telemetry#29587 and therefore fixes open-telemetry#22045

**Testing:** 

Unit tests; manually Tested on my laptop with the following
configuration:

```
receivers:
  hostmetrics:
    collection_interval: 10s
    scrapers:
      load:

processors:
  resourcedetection:
    detectors: ["system"]
    system:
      resource_attributes:
        host.mac:
          enabled: true

exporters:
  debug:
    verbosity: detailed

service:
  pipelines:
    metrics:
      receivers: [hostmetrics]
      processors: [resourcedetection]
      exporters: [debug]
```

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processor/resourcedetection] Add host.mac to system detector mx-psi/opentelemetry-collector-contrib
1 participant
@mx-psi