Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[kafka] Expose resolve_canonical_bootstrap_servers_only #26022

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[kafka] Expose resolve_canonical_bootstrap_servers_only #26022

merged 1 commit into from
Nov 14, 2023

Conversation

gebn
Copy link
Contributor

@gebn gebn commented Aug 21, 2023 •
edited
Loading

Description: The latest release of IBM/sarama includes the resolve_canonical_bootstrap_servers_only setting for client.dns.lookup. In a GSSAPI context, this enables replacing a list of brokers with a single name that resolves to all of the underlying IPs. Previously this would fail with a Kerberos error. This PR exposes the new option in collector config.

Testing: Added new cases to check the option is set correctly.

Documentation: Added a description of the parameter to the relevant READMEs.

@gebn gebn marked this pull request as ready for review August 21, 2023 22:22
@gebn gebn requested a review from a team August 21, 2023 22:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 5, 2023
mx-psi
mx-psi reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay @MovieStoreGuy can you take a look as codeowners?

@github-actions github-actions bot removed the Stale label Sep 6, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 20, 2023
@mx-psi
Copy link
Member

mx-psi commented Sep 20, 2023

@pavolloffay @MovieStoreGuy ping

@mx-psi mx-psi removed the Stale label Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 5, 2023
@gebn
Copy link
Contributor Author

gebn commented Oct 16, 2023

@pavolloffay @MovieStoreGuy ping, please let me know of any amendments!

@github-actions github-actions bot removed the Stale label Oct 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 1, 2023
@gebn
Copy link
Contributor Author

gebn commented Nov 11, 2023

Sarama has since been upgraded automatically in main, so I've rebased and removed that commit - the diff is now much more related to only the intent. I'm still keen to get this merged to simplify our Kafka configuration - please let me know what needs to be done. Build failures appear unrelated to the change.

@dmitryax @MovieStoreGuy @mx-psi

@github-actions github-actions bot removed the Stale label Nov 12, 2023
@gebn
Copy link
Contributor Author

gebn commented Nov 13, 2023

@mx-psi Apologies, there is a trivial import error, I'll fix this this evening - unable to at work.

@gebn
Copy link
Contributor Author

gebn commented Nov 13, 2023

All sorted @mx-psi

@mx-psi mx-psi merged commit 6af33d6 into open-telemetry:main Nov 14, 2023
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
@gebn gebn deleted the kafka-bootstrap branch November 14, 2023 08:58
@gebn gebn mentioned this pull request Nov 16, 2023
Merged
3 tasks
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@gebn @RoryCrispin
[kafka] Expose resolve_canonical_bootstrap_servers_only (open-telemet…
faa7b92 
…ry#26022)

**Description:** The latest release of IBM/sarama includes the
`resolve_canonical_bootstrap_servers_only` setting for
`client.dns.lookup`. In a GSSAPI context, this enables replacing a list
of brokers with a single name that resolves to all of the underlying
IPs. Previously this would fail with a Kerberos error. This PR exposes
the new option in collector config.

**Testing:** Added new cases to check the option is set correctly.

**Documentation:** Added a description of the parameter to the relevant
READMEs.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@TylerHelmuth TylerHelmuth

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/kafka receiver/kafka receiver/kafkametrics
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gebn @mx-psi @TylerHelmuth