Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[pkg/ottl] Unexport the grammar's constants #29925

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Dec 15, 2023

Description:
On the continuing quest to unexport the grammar, this PR unexports the grammar's constants.

Depends on #29924

Link to tracking Issue:
Related to #22744

@evan-bradley
Copy link
Contributor

A good follow-up at some point could be to move the definitions in the grammar.go file (or anything related) into an internal package to prevent accidentally exposing anything we don't want public.

@evan-bradley evan-bradley merged commit 7268d84 into open-telemetry:main Dec 18, 2023
@TylerHelmuth TylerHelmuth deleted the ottl-hide-consts branch December 18, 2023 15:57
@github-actions github-actions bot added this to the next release milestone Dec 18, 2023
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
**Description:**
On the continuing quest to unexport the grammar, this PR unexports the
grammar's constants.

Depends on
open-telemetry#29924

Link to tracking Issue:
Related to
open-telemetry#22744
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants