Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[chore] Docs/seed docs folder with some testing information #30172

Conversation

hughesjj
Copy link
Contributor

Description: Adds some documentation around test targets to a new (to this project) docs folder, similar to what we have in opentelemetry-collector (upstream)

Link to tracking Issue: 30166

Testing: N/A

Documentation: Adds documentation to docs folder but not linked to CONTRIBUTORS.md until we get some discussion rolling about how to potentially reorganize such

@hughesjj hughesjj changed the title Docs/seed docs folder with some testing information [chore] Docs/seed docs folder with some testing information Dec 21, 2023
@hughesjj
Copy link
Contributor Author

If accepted, I believe we should add the Skip Changelog label as per CONTRIBUTING.md guidelines around adding/updating docs

@hughesjj hughesjj marked this pull request as ready for review December 22, 2023 01:47
@hughesjj hughesjj requested review from a team and atoulme December 22, 2023 01:47
@hughesjj hughesjj mentioned this pull request Dec 22, 2023
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 22, 2023
@atoulme
Copy link
Contributor

atoulme commented Dec 22, 2023

Dead link:

FILE: docs/testing.md
  [✖] ./internal/coreinternal/scraperinttest → Status: 400 [Error: ENOENT: no such file or directory, access '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/docs/internal/coreinternal/scraperinttest'] {

specify a file and not a path in link
Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
@bryan-aguilar bryan-aguilar added the ready to merge Code review completed; ready to merge by maintainers label Jan 3, 2024
@bogdandrutu bogdandrutu merged commit 7dcc7a0 into open-telemetry:main Jan 10, 2024
89 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 10, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…emetry#30172)

**Description:** Adds some documentation around test targets to a new
(to this project) `docs` folder, similar to what we have in
`opentelemetry-collector` (upstream)

**Link to tracking Issue:**
[`30166`](open-telemetry#30166)

**Testing:** N/A

**Documentation:** Adds documentation to `docs` folder but not linked to
`CONTRIBUTORS.md` until we get some discussion rolling about how to
potentially reorganize such

---------

Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants