[processor/metricstransform]: Add scaling exponential histogram support #34039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/metricstransform
jpkrohling
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
The code looks sane, but I need help from someone who understands about histograms.
@carrieedwards, are you available to review this one?
carrieedwards
approved these changes
Jul 19, 2024
Done :) |
|
@jpkrohling @dmitryax the PR is ready for another review / to be merged |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…rt (open-telemetry#34039) **Description:** This PR adds support for the exponential histograms for the `experimental_scale_value` in the metricstransformprocessor. The scaling works by scaling the middle value of the first bucket (the one that corresponds to the offset) and finding the offset corresponding to this new value (the method used is described here: https://opentelemetry.io/docs/specs/otel/metrics/data-model/#all-scales-use-the-logarithm-function). The buckets are actually unchanged because they are "shifted" by the new offset. I initially remapped all the values but I ended up always having the same buckets so I left the buckets untouched to make the code simpler and save on performance. **Link to tracking Issue:** open-telemetry#29803 **Testing:** unit test + e2e local test
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds support for the exponential histograms for the
experimental_scale_valuein the metricstransformprocessor.The scaling works by scaling the middle value of the first bucket (the one that corresponds to the offset) and finding the offset corresponding to this new value (the method used is described here: https://opentelemetry.io/docs/specs/otel/metrics/data-model/#all-scales-use-the-logarithm-function).
The buckets are actually unchanged because they are "shifted" by the new offset. I initially remapped all the values but I ended up always having the same buckets so I left the buckets untouched to make the code simpler and save on performance.
Link to tracking Issue: #29803
Testing: unit test + e2e local test