Add Prometheus Remote Write Exporter supporting Cortex - helper #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for service package
huyan0
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
huyan0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
- Coverage 91.42% 91.42% -0.01%
==========================================
Files 248 249 +1
Lines 17219 17313 +94
==========================================
+ Hits 15743 15828 +85
- Misses 1064 1074 +10
+ Partials 412 411 -1
Continue to review full report at Codecov.
|
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1548) Bumps [boto3](https://github.com/boto/boto3) from 1.22.10 to 1.22.11. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.22.10...1.22.11) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs implementing a Prometheus remote write exporter supporting Cortex. PR #1525 contains all the code. Note that ~100 lines of code are coming from changes in go.mod
Description: This PR adds helper methods used by the exporter, including functionalities such as sanitizing strings and creating Prometheus labels from OTLP labels.
helper.go: helper functions that cortex.go uses.
testutil_test.go: constant values used in tests for all files in the project.
Documentation:
cc: @huyan0 @alolita
Request for review: @jmacd @bogdandrutu @annanay25 @gouthamve @open-telemetry/collector-approvers @open-telemetry/collector-maintainers