Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Moved some components out of internal #191

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Moved some components out of internal #191

merged 1 commit into from
Jul 24, 2019

Conversation

owais
Copy link
Contributor

@owais owais commented Jul 23, 2019

This commit moves two processors and an error helper outside the
internal package so they can be imported and used by OT service
derivatives.

// See the License for the specific language governing permissions and
// limitations under the License.

package oterr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a package description.

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files         104      105    +1     
  Lines        6094     6094           
=======================================
  Hits         4433     4433           
  Misses       1435     1435           
  Partials      226      226
Impacted Files Coverage Δ
processor/nodebatcher/options.go 100% <ø> (ø)
processor/queued/queued_processor.go 47.61% <ø> (ø)
processor/nodebatcher/metrics.go 0% <ø> (ø)
processor/queued/options.go 60.52% <ø> (ø)
service/telemetry.go 72.97% <ø> (ø) ⬆️
processor/nodebatcher/factory.go 95.12% <ø> (ø)
processor/nodebatcher/node_batcher.go 93.83% <ø> (ø)
processor/queued/factory.go 90.9% <ø> (ø)
internal/internal.go 71.42% <ø> (-16.81%) ⬇️
receiver/vmmetricsreceiver/vm_metrics_collector.go 13.86% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9233b6c...fdaea21. Read the comment docs.

This commit moves two processors and an error helper outside the
internal package so they can be imported and used by OT service
derivatives.
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I'm just not sure about the name of the package: oterr ... but I have no good suggestions... 🤷‍♂

@owais
Copy link
Contributor Author

owais commented Jul 24, 2019

I don't have any other ideas either. I took the oterr package name idea from awserr https://docs.aws.amazon.com/sdk-for-go/api/aws/awserr/

@pjanotti
Copy link
Contributor

We can rename later if a good idea comes to mind...

@pjanotti pjanotti merged commit 091e19d into open-telemetry:master Jul 24, 2019
@owais owais deleted the minor-refactor branch August 8, 2019 16:49
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Provide conformance tests for tracers

The test harness may be used to ensure that a given tracer behaves
according to the expectations set by the API.

* Add `ToMatchError` matcher

* Use DeepEqual to compare unknown types in matchers

Unlike basic `==`/`!=`, `reflect.DeepEqual` can compare arbitrary
types (e.g., `[]string` to `[]string`)

* Use struct instead of string for test context key
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 0.18.0 to 0.19.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v0.18.0...v0.19.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.2.1 to 1.4.0.
- [Release notes](https://github.com/helm/chart-releaser-action/releases)
- [Commits](helm/chart-releaser-action@v1.2.1...v1.4.0)

---
updated-dependencies:
- dependency-name: helm/chart-releaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants