-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Moved some components out of internal #191
Conversation
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package oterr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a package description.
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 72.74% 72.74%
=======================================
Files 104 105 +1
Lines 6094 6094
=======================================
Hits 4433 4433
Misses 1435 1435
Partials 226 226
Continue to review full report at Codecov.
|
This commit moves two processors and an error helper outside the internal package so they can be imported and used by OT service derivatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I'm just not sure about the name of the package: oterr
... but I have no good suggestions... 🤷♂
I don't have any other ideas either. I took the |
We can rename later if a good idea comes to mind... |
* Provide conformance tests for tracers The test harness may be used to ensure that a given tracer behaves according to the expectations set by the API. * Add `ToMatchError` matcher * Use DeepEqual to compare unknown types in matchers Unlike basic `==`/`!=`, `reflect.DeepEqual` can compare arbitrary types (e.g., `[]string` to `[]string`) * Use struct instead of string for test context key
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v0.18.0...v0.19.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.2.1 to 1.4.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@v1.2.1...v1.4.0) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This commit moves two processors and an error helper outside the
internal package so they can be imported and used by OT service
derivatives.