-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Extract ConfigFactory in a ParserProvider interface #2868
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
- Coverage 91.67% 91.65% -0.03%
==========================================
Files 287 291 +4
Lines 15250 15272 +22
==========================================
+ Hits 13981 13997 +16
- Misses 866 869 +3
- Partials 403 406 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good change, just one comment to be updated.
d752530
to
1b61fe8
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
c5822bf
to
3be3fa7
Compare
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com