Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extract ConfigFactory in a ParserProvider interface #2868

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team March 31, 2021 15:24
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #2868 (fd28625) into main (a31ad5b) will decrease coverage by 0.02%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2868      +/-   ##
==========================================
- Coverage   91.67%   91.65%   -0.03%     
==========================================
  Files         287      291       +4     
  Lines       15250    15272      +22     
==========================================
+ Hits        13981    13997      +16     
- Misses        866      869       +3     
- Partials      403      406       +3     
Impacted Files Coverage Δ
config/configparser/config.go 98.55% <ø> (ø)
service/internal/builder/builder.go 100.00% <ø> (ø)
service/parserprovider/file.go 50.00% <50.00%> (ø)
service/parserprovider/setflag.go 73.91% <60.00%> (ø)
service/parserprovider/inmemory.go 66.66% <66.66%> (ø)
service/application.go 78.22% <85.71%> (+0.88%) ⬆️
service/parserprovider/default.go 100.00% <100.00%> (ø)
service/parserprovider/flags.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31ad5b...fd28625. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good change, just one comment to be updated.

service/parserprovider/default.go Outdated Show resolved Hide resolved
service/application.go Outdated Show resolved Hide resolved
service/application.go Outdated Show resolved Hide resolved
service/application.go Outdated Show resolved Hide resolved
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
service/parserprovider/inmemory.go Outdated Show resolved Hide resolved
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
@tigrannajaryan tigrannajaryan merged commit 5f3e4ec into open-telemetry:main Apr 12, 2021
@bogdandrutu bogdandrutu deleted the parserloader branch April 12, 2021 19:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants