Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to OTLP 1.1, regenerate protos and pdata #9588

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Feb 14, 2024

Description: Updates to OTLP 1.1, published in January 2024. Updates the otel/build-protobuf Docker image to the current release label.

User-visible protocol changes: Adds Span flags and SpanLink flags.

Link to tracking Issue:
Fixes #9587
Fixes #9550

Testing: make test

Documentation: Could not find any documentation on this process, added some in CONTRIBUTING.md.

@jmacd jmacd marked this pull request as ready for review February 14, 2024 20:34
@jmacd jmacd requested review from a team and dmitryax February 14, 2024 20:34
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (939c740) 90.62% compared to head (284a065) 90.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9588      +/-   ##
==========================================
- Coverage   90.62%   90.61%   -0.02%     
==========================================
  Files         347      347              
  Lines       18238    18250      +12     
==========================================
+ Hits        16528    16537       +9     
- Misses       1381     1383       +2     
- Partials      329      330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the documentation for the process 👍🏻

@bogdandrutu
Copy link
Member

Thanks for this. In the future I would prefer to have separate PRs for bumping protos vs adding the new fields (easier to review).

@bogdandrutu bogdandrutu merged commit f360e4c into open-telemetry:main Feb 20, 2024
49 of 63 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to OTLP 1.1 Make span flags accessible in pdata Span
3 participants