Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ci] add license lint check #233

Closed
fatsheep9146 opened this issue Jul 26, 2022 · 4 comments · Fixed by #825
Closed

[ci] add license lint check #233

fatsheep9146 opened this issue Jul 26, 2022 · 4 comments · Fixed by #825
Assignees
Labels
enhancement New feature or request

Comments

@fatsheep9146
Copy link
Contributor

Feature Request

I think the repo missing license lint check.

I submit a pr with a new but without license info, all checks are passed

a14ac25

Describe the solution you'd like:

What do you want to happen instead? What is the expected behavior?

Throw out check failed for pull request, just like the collector repo does

https://github.com/open-telemetry/opentelemetry-collector/blob/74cca75ee1b84b8da72b73122984b52b7857489f/.github/workflows/build-and-test.yml#L79-L80

@fatsheep9146 fatsheep9146 added the enhancement New feature or request label Jul 26, 2022
@cartersocha
Copy link
Contributor

Is there an equivalent of this in the dotnet repo @reyang ?

@reyang
Copy link
Member

reyang commented Jul 26, 2022

Is there an equivalent of this in the dotnet repo @reyang ?

Nope, I guess the model is different. OpenTelemetry .NET does not redistribute any source or binary.
I can see how this is important for demo and collector.

@cartersocha
Copy link
Contributor

@bogdandrutu or @tigrannajaryan do y’all have suggestions or guidance on how the collector repo handles licensing checks & general licensing? We could use some help maturing our story here

@cartersocha
Copy link
Contributor

@fatsheep9146 all the need or updated services should have basic license info in one place now. I did a v1 review.

We could potentially add this now or decide we don’t need it?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants