Add license check #825

austinlparker · 2023-04-05T13:40:44Z

Fixes #233

This PR adds two new make targets (checklicense and addlicense) and updates the GitHub PR checks to scan for valid copyright/license declarations.

.licenserc.json

puckpuck · 2023-04-06T00:20:03Z

Should we include .yamllint, *.sh, Makefile in the list of license check patterns?

puckpuck · 2023-04-06T00:31:00Z

Also need to include *.gradle, Gemfile, *.gradle.kts, and *.kt

There's also a grafana.ini file we may want to include in this, but I'm indifferent if we don't.

Going over the changes, I noticed a couple of Dockerfile that had both the short form and long form copyright notices. ad, cart, checkout, currency, loadgenerator, payment, productcatalog, and recommendation, all have both notices in their header. I assume this may be because of extra blank lines in the file.

julianocosta89 · 2023-04-06T05:21:25Z

Should we include .yamllint, *.sh, Makefile in the list of license check patterns?

+1 to yes!

I don't mind the yamllint, but *.sh and Makefile were pretty much built from scratch.

cartersocha · 2023-04-06T05:45:00Z

Lgtm outside of Pierre's and juliano's comment

src/adservice/Dockerfile

src/adservice/src/main/java/oteldemo/AdService.java

src/cartservice/src/Dockerfile

src/loadgenerator/Dockerfile

src/recommendationservice/Dockerfile

fatsheep9146 · 2023-04-06T08:21:15Z

some small nits

* Changelog entry for PR 797 (open-telemetry#803) * Changelog entry for PR 797 * Changelog ordered * lint fix * Move Michael Maxwell to Emeritus (open-telemetry#800) Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Bump actions/stale from 7 to 8 (open-telemetry#804) Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * use absolute path (open-telemetry#806) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use yamllint 1.3.0 (open-telemetry#807) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [chore] add kubernetes manifest (open-telemetry#791) * add kubernetes manifest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add kubernetes manifest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use absolute path Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Cart Service - minor cleanup (open-telemetry#801) * Cart Service - minor cleanup * fix file encoding Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> * [frontend] update JS SDKs (open-telemetry#805) * update JS SDKs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update JS SDKs for frontend Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix formatting Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: Austin Parker <austin@ap2.io> * Otlp env variables (open-telemetry#809) * standardize OTEL_* env vars Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * standardize OTEL_* env vars Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * [frontend] fix http.status_code on error (open-telemetry#810) * fix http.status_code on error Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only end span when synthetic Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix http.status_code on error Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Fix to shipping calculation (open-telemetry#814) * reduce kafka mem allocation (open-telemetry#798) * add kafka mem allocation to changelog (open-telemetry#817) * Changed web tracer to use batch processor (open-telemetry#819) * Updated ENV_PLATFORM flag (open-telemetry#818) * Added elastic's forked opentelemetry demo repo (open-telemetry#813) * Update collector (open-telemetry#822) * use async php runtime (open-telemetry#823) * use async php runtime To better demonstrate PHP's capabilities, use an async runtime (react/http). This means that batch exporters (traces and metrics) are long-lived and more efficient, and they can now use export delays to only send batches after the configured time has elapsed. Update auto-instrumentation extension to install from PECL (the preferred mechanism, which we've just set up), and bump other dependencies to their latest beta versions. * update changelog * Add license check (open-telemetry#825) * adding license check * add/update copyrights * add checklicense to gh checks * add make target to add license * fixup * swap to short form license * add copyright to yaml * and the rest of the yaml * fixup * address comments * fix prometheus scrape bug (open-telemetry#827) Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Austin Parker <austin@ap2.io> * prep for beta (open-telemetry#828) --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Devrim Demiroz <62701796+devrimdemiroz@users.noreply.github.com> Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io> Co-authored-by: Martin Kuba <martin@martinkuba.com> Co-authored-by: Bahubali Shetti <billshetti@gmail.com> Co-authored-by: Brett McBride <brett@deakin.edu.au> Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* adding license check * add/update copyrights * add checklicense to gh checks * add make target to add license * fixup * swap to short form license * add copyright to yaml * and the rest of the yaml * fixup * address comments

austinlparker added 4 commits April 5, 2023 08:03

adding license check

2c716d8

add/update copyrights

c5d4de3

add checklicense to gh checks

8ca7ecb

add make target to add license

6b61266

austinlparker requested a review from a team April 5, 2023 13:40

github-actions bot requested review from jack-berg, mateuszrzeszutek and trask April 5, 2023 13:41

fixup

1bca138

trask reviewed Apr 5, 2023

View reviewed changes

.licenserc.json Outdated Show resolved Hide resolved

austinlparker added 4 commits April 5, 2023 14:29

swap to short form license

fb39157

add copyright to yaml

23c80ff

and the rest of the yaml

b8d643b

fixup

6c7079c

cartersocha approved these changes Apr 6, 2023

View reviewed changes

cartersocha added the in-progress This issue is actively being worked on label Apr 6, 2023