Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[chore] - update kubernetes manifests to 1.7 release #1305

Merged
merged 4 commits into from
Dec 27, 2023
Merged

[chore] - update kubernetes manifests to 1.7 release #1305

merged 4 commits into from
Dec 27, 2023

Conversation

puckpuck
Copy link
Contributor

Updates k8s manifest to 1.7 release

make generate-kubernetes-manifests

@puckpuck
update to 1.7 release
efa7f80 
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team December 19, 2023 16:30
julianocosta89
julianocosta89 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Should we also create the namespace otel-demo in this file?

@puckpuck
Copy link
Contributor Author

That's a good idea. I will figure out the right way to do this with the generator script.

@mviitane
Copy link
Member

A bit related comment:
Our helm and kubectl install commands in the docs are not aligned with what comes to the namespace. Helm install doesn't include namespace at all, even if it should?, and leads to installing to the default namespace.

@puckpuck
add create namespace
3423f81 
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck
Copy link
Contributor Author

I added a create namespace manifest the hard way to the generated output. Unfortunately, the helm template ... command will not emit this for us.

@julianocosta89 can you take another look?

@julianocosta89 julianocosta89 merged commit ca44eaf into open-telemetry:main Dec 27, 2023
26 checks passed
@puckpuck puckpuck deleted the update-k8s-manifest branch December 27, 2023 13:21
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck @julianocosta89
[chore] - update kubernetes manifests to 1.7 release (open-telemetry#…
0e03d1d 
…1305)

* update to 1.7 release

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* add create namespace

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@mviitane mviitane mviitane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@puckpuck @mviitane @fatsheep9146 @julianocosta89