-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Variable paymentservice error rate and introduce loyalty level attributes #1815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rcastley 👋🏽
Thanks for suggesting this.
I'd change a bit the approach though. Instead of having 75% set on the code, ideally we would configure this directly on the Feature Flag, using fractional evaluation: https://openfeature.dev/specification/glossary/#fractional-evaluation
Imagine a slider, where we select the % of failure we want to have.
Hardcoding 75% will create some unexpected behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Just a typo that needs fix, but should be good to go! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rcastley this is great!
Changes
Introduced an enhancement to the feature flag paymentServiceFailure:
app.loyalty.level
also added as a span attribute. Gold will show errors when feature flag set.pino
to include theservice.name
in log entries and also change from numeric level to text level e.g. info, warn etc.This makes for a more interesting use case when the payment service fails. Only the
gold
loyalty level will show errors, all other levels will show success.Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.