Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Variable paymentservice error rate and introduce loyalty level attributes #1815

Merged
merged 15 commits into from
Dec 12, 2024

Conversation

rcastley
Copy link
Contributor

@rcastley rcastley commented Dec 6, 2024

Changes

Introduced an enhancement to the feature flag paymentServiceFailure:

  • Selectable error rate percentage in the Flagd UI
  • app.loyalty.level also added as a span attribute. Gold will show errors when feature flag set.
  • Changed pino to include the service.name in log entries and also change from numeric level to text level e.g. info, warn etc.

This makes for a more interesting use case when the payment service fails. Only the gold loyalty level will show errors, all other levels will show success.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@rcastley rcastley requested a review from a team as a code owner December 6, 2024 18:43
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rcastley 👋🏽

Thanks for suggesting this.
I'd change a bit the approach though. Instead of having 75% set on the code, ideally we would configure this directly on the Feature Flag, using fractional evaluation: https://openfeature.dev/specification/glossary/#fractional-evaluation
Imagine a slider, where we select the % of failure we want to have.

Hardcoding 75% will create some unexpected behaviour.

@github-actions github-actions bot added docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released labels Dec 9, 2024
@rcastley rcastley changed the title Reduce paymentservice error rate and introduce version and tenant level attributes Variable paymentservice error rate and introduce loyalty level attributes Dec 12, 2024
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just a typo that needs fix, but should be good to go! 🚀

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rcastley this is great!

@puckpuck puckpuck merged commit 1f30247 into open-telemetry:main Dec 12, 2024
30 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants