Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[chore] drop _SERVICE for dependent service env variables #1897

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Jan 10, 2025

Changes

Drops _SERVICE from the environment variables associated with dependent services.

This is part of getting all services renamed based on the overall #1788 effort for all components in the demo.

Services affected by this:

  • grafana
  • jaeger
  • kafka
  • prometheus

This change also includes an update to a required component in the PHP-based quote service. Without this, the quote service would cause an error on startup.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@puckpuck puckpuck requested a review from a team as a code owner January 10, 2025 04:39
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Jan 10, 2025
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the src/quote/composer.json from this PR.

@julianocosta89 julianocosta89 merged commit d534e42 into open-telemetry:main Jan 14, 2025
32 checks passed
@puckpuck puckpuck deleted the rename.dependent-services branch January 14, 2025 13:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants