Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[shippingservice] - Add events #344

Merged

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Aug 25, 2022

It seems that #54 was closed without having all items checked.

Changes

Adding events to the spans get-quote and ship-order.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@julianocosta89 julianocosta89 requested a review from a team August 25, 2022 21:17
@julianocosta89 julianocosta89 self-assigned this Aug 25, 2022
@julianocosta89 julianocosta89 added the enhancement New feature or request label Aug 25, 2022
@julianocosta89
Copy link
Member Author

@cartersocha and @GaryPWhite I believe we have to take a look at #54.

@cartersocha
Copy link
Contributor

Re-opened. I think if you reference it a certain way in a pr it auto closes an issue.

We’ll need to be a bit better on that.

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austinlparker austinlparker merged commit c5831e8 into open-telemetry:main Aug 27, 2022
@julianocosta89 julianocosta89 deleted the shippingservice-add-events branch August 27, 2022 06:24
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Add events to shippingservice

* Add changelog
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants