Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding front end exporter custom url #512

Merged
merged 9 commits into from
Oct 21, 2022

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Oct 21, 2022

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@xoscar xoscar requested a review from a team October 21, 2022 18:05
@puckpuck
Copy link
Contributor

puckpuck commented Oct 21, 2022

It's not in this PR, but we should set the env variable up in docker-compose.yaml to not set a default value and rely only on the .env file.

     - PUBLIC_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:4318/v1/traces

should become

    - PUBLIC_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT

@cartersocha
Copy link
Contributor

@xoscar please add a change log entry and I'll merge

@puckpuck puckpuck merged commit 98f8bf5 into open-telemetry:main Oct 21, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* adding front end exporter custom url

* adding front end exporter custom url

* adding front end exporter custom url

* adding front end exporter custom url

* adding front end exporter custom url

* updating CHANGELOG
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants