Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[frontend] Fix minor bugs #670

Merged
merged 2 commits into from
Jan 4, 2023
Merged

[frontend] Fix minor bugs #670

merged 2 commits into from
Jan 4, 2023

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Jan 3, 2023 •
edited
Loading

Changes

Towards #327

  • Page title
  • When an item is added to the cart we get 2 scroll bars whenever clicking on the cart icon.

Also fixed typo.

@julianocosta89 julianocosta89 requested a review from a team January 3, 2023 09:56
@julianocosta89 julianocosta89 mentioned this pull request Jan 3, 2023
Closed
10 tasks
@julianocosta89 julianocosta89 self-assigned this Jan 3, 2023
@julianocosta89 julianocosta89 added the enhancement New feature or request label Jan 3, 2023
mviitane
mviitane approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89 julianocosta89 merged commit 0417b44 into open-telemetry:main Jan 4, 2023
@julianocosta89 julianocosta89 deleted the frontend-minor-adjusts branch January 4, 2023 06:12
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@julianocosta89 @cartersocha
Fix minor FE bugs (open-telemetry#670)
cb3883c 
Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@mviitane mviitane mviitane approved these changes

Assignees

@julianocosta89 julianocosta89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianocosta89 @fatsheep9146 @mviitane @cartersocha