Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix shipping cost update when new item is added to cart #799

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

martinkuba
Copy link
Contributor

@martinkuba martinkuba commented Mar 21, 2023

Changes

This fixes the shipping cost update when any parameters (like list of products) for the shipping API call change.

The react-query component needs a unique key to know whether to make a network call or use cached data. The query parameters are used as a unique key. This is documented here.

The original bug is listed in #327

@martinkuba martinkuba requested a review from a team March 21, 2023 04:03
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinkuba! 🤩

@julianocosta89 julianocosta89 merged commit aa38fce into open-telemetry:main Mar 21, 2023
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
…ry#799)

* add all variables to shipping react query as a unique key

* updated changelog
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
…ry#799)

* add all variables to shipping react query as a unique key

* updated changelog
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants