Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename AddActivitySource to AddSource, use params #1036

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 10, 2020

Follow up on:

Changes

  • Renamed AddActivitySource to AddSource
  • Take the params approach.

I will send a separate PR to clean up the CHANGELOG.md as it is becoming messy now.

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team August 10, 2020 23:19
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #1036 into master will decrease coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
- Coverage   77.17%   77.11%   -0.06%     
==========================================
  Files         221      221              
  Lines        6164     6162       -2     
==========================================
- Hits         4757     4752       -5     
- Misses       1407     1410       +3     
Impacted Files Coverage Δ
...umentation.Http/TracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
src/OpenTelemetry/Trace/TracerProviderBuilder.cs 89.18% <66.66%> (+9.70%) ⬆️
...ation.SqlClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ckExchangeRedis/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Metrics/CounterMetricSdkBase.cs 83.33% <0.00%> (-13.34%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 82.35% <0.00%> (-4.42%) ⬇️

@cijothomas cijothomas merged commit ce0bf3f into master Aug 11, 2020
@cijothomas cijothomas deleted the reyang/AddSource branch August 11, 2020 01:02
@reyang reyang mentioned this pull request Aug 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants