Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ZipkinExporter: HttpClientFactory option #2654

Merged
merged 9 commits into from
Nov 23, 2021

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Nov 21, 2021

Changes

  • Adds the same HttpClientFactory option we have on JaegerExporterOptions to ZipkinExporterOptions.
  • Adds IHttpClientFactory integration when IDeferredTracerProviderBuilder is used.

TODOs

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests

@CodeBlanch CodeBlanch requested a review from a team November 21, 2021 04:58
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #2654 (aefbf9d) into main (f7d3227) will increase coverage by 0.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
+ Coverage   81.32%   82.25%   +0.93%     
==========================================
  Files         247      247              
  Lines        8664     8691      +27     
==========================================
+ Hits         7046     7149     +103     
+ Misses       1618     1542      -76     
Impacted Files Coverage Δ
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 97.67% <100.00%> (+95.34%) ⬆️
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 90.47% <100.00%> (+5.47%) ⬆️
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 88.42% <100.00%> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 97.56% <100.00%> (+91.67%) ⬆️
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <100.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 74.28% <0.00%> (+2.85%) ⬆️
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 87.06% <0.00%> (+4.31%) ⬆️
...Exporter.Jaeger/Implementation/JaegerHttpClient.cs 44.00% <0.00%> (+44.00%) ⬆️

@cijothomas cijothomas merged commit bc0e8af into open-telemetry:main Nov 23, 2021
@CodeBlanch CodeBlanch deleted the zipkin-httpclientfactory branch November 23, 2021 19:26
Comment on lines +43 to +44
* `MaxPayloadSizeInBytes`: Maximum payload size - for .NET versions **other**
than 4.5.2 (default 4096).
Copy link
Contributor

@mic-max mic-max Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 4.6.1 the lowest version we support now. I guess this comment is from when it was supported, and we no longer need to call it out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants