Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove metric related options from ConsoleExporterOptions #2929

Conversation

alanwest
Copy link
Member

Follow up from #2717. Applying the same pattern to the console exporter.

@alanwest alanwest requested a review from a team February 22, 2022 23:41
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2929 (b1c86e0) into main (843d6fd) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
+ Coverage   83.87%   83.92%   +0.04%     
==========================================
  Files         254      254              
  Lines        8918     8918              
==========================================
+ Hits         7480     7484       +4     
+ Misses       1438     1434       -4     
Impacted Files Coverage Δ
...heus/Implementation/PrometheusCollectionManager.cs 82.27% <0.00%> (+2.53%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit 644ba5b into open-telemetry:main Feb 23, 2022
@alanwest alanwest deleted the alanwest/metric-options-console-exporter branch February 23, 2022 18:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants