Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use ToOtlpAttribute method for traces #3274

Merged

Conversation

alanwest
Copy link
Member

ToOtlpAttribute method is now used for transforming attributes on all the things: traces, metrics, logs, resources.

There will be a failing test on this PR which will be resolved by merging #3273.

@alanwest alanwest requested a review from a team May 11, 2022 20:00
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3274 (eacc315) into main (d983cb1) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
+ Coverage   85.32%   85.55%   +0.23%     
==========================================
  Files         263      263              
  Lines        9520     9487      -33     
==========================================
- Hits         8123     8117       -6     
+ Misses       1397     1370      -27     
Impacted Files Coverage Δ
...metryProtocol/Implementation/ActivityExtensions.cs 94.53% <100.00%> (+4.25%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 86.36% <0.00%> (+9.09%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@cijothomas cijothomas merged commit a383463 into open-telemetry:main May 16, 2022
@alanwest alanwest deleted the alanwest/otlp-activity-attributes branch September 30, 2022 22:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants