Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[api-logs] Removed default parameter from the EmitLog API #4559

Merged

Conversation

CodeBlanch
Copy link
Member

Relates to #4433

See #4552 (comment)

Changes

  • Updates the EmitLog API so that it doesn't use default parameters

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team June 7, 2023 21:15
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #4559 (e961daa) into main (f786f59) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4559      +/-   ##
==========================================
- Coverage   85.23%   85.18%   -0.05%     
==========================================
  Files         320      320              
  Lines       12677    12678       +1     
==========================================
- Hits        10805    10800       -5     
- Misses       1872     1878       +6     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Logs/NoopLogger.cs 66.66% <ø> (ø)
.../OpenTelemetry/Logs/ILogger/OpenTelemetryLogger.cs 87.73% <ø> (ø)
src/OpenTelemetry/Logs/LoggerSdk.cs 100.00% <ø> (ø)
src/OpenTelemetry.Api/Logs/Logger.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 1143c52 into open-telemetry:main Jun 7, 2023
@CodeBlanch CodeBlanch deleted the api-logs-emitlog-codereview branch June 7, 2023 21:57
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants