Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OTLP LogExporter limits configuration by env. var. #4887

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 26, 2023

Fixes #4156

Changes

Added support for OTEL_LOGRECORD_ATTRIBUTE_VALUE_LENGTH_LIMIT
and OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMIT.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek force-pushed the otlp-exporter-limits-by-env-vars branch from f459b4c to fb20faa Compare September 26, 2023 11:26
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4887 (0d0b889) into main (bc1badf) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4887      +/-   ##
==========================================
+ Coverage   82.91%   83.06%   +0.14%     
==========================================
  Files         294      294              
  Lines       12188    12198      +10     
==========================================
+ Hits        10106    10132      +26     
+ Misses       2082     2066      -16     
Flag Coverage Δ
unittests 83.06% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etryProtocol/Implementation/LogRecordExtensions.cs 80.00% <100.00%> (ø)
...elemetryProtocol/Implementation/SdkLimitOptions.cs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review September 26, 2023 11:48
@Kielek Kielek requested a review from a team September 26, 2023 11:48
Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Sep 27, 2023
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 6e2f442 into open-telemetry:main Sep 27, 2023
@Kielek Kielek deleted the otlp-exporter-limits-by-env-vars branch September 27, 2023 17:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for OTEL_LOGRECORD_ATTRIBUTE_VALUE_LENGTH_LIMIT and OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMIT
4 participants