-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rewrite Prometheus exporter tests #4274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI @hexdigest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4274 +/- ##
=====================================
Coverage 83.5% 83.5%
=====================================
Files 183 183
Lines 14207 14207
=====================================
+ Hits 11869 11871 +2
Misses 2110 2110
+ Partials 228 226 -2 |
dmathieu
approved these changes
Jul 3, 2023
hanyuancheung
approved these changes
Jul 4, 2023
dashpole
pushed a commit
to dashpole/opentelemetry-go
that referenced
this pull request
Jul 7, 2023
* Remove TesInvalidInsrtrumentForPrometheusIsIgnored * Reimplement ConcurrentSafe test * Add TestIncompatibleMeterName
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
pkg:exporter:prometheus
Related to the Prometheus exporter package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4270
Rewrite
TesInvalidInsrtrumentForPrometheusIsIgnored
intoTestIncompatibleMeterName
- it was not being executed (sic!) because of a bad name (my fault).The test should be more readable and it uses exported API.
It is also more stable and does not uses goroutines which were not needed.
The test is based on
TestPrometheusExporter
.I have also created Meter name validation opentelemetry-specification#3579
Rewrite
TestCollectConcurrentSafe
intoTestCollectorConcurrentSafe
.I reimplemented the concurrency test so that it uses exported API.
It should not leak any goroutines (as previously the goroutines were leaking).
I double-checked that
exporter.Collect
is indeed called concurrently (I used this hack to triple-check):