fix(metric, log): merge explicit resource with environment variables #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
requested review from
MrAlias,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5773 +/- ##
=======================================
- Coverage 84.6% 84.5% -0.1%
=======================================
Files 272 272
Lines 22778 22784 +6
=======================================
- Hits 19271 19269 -2
- Misses 3166 3172 +6
- Partials 341 343 +2 |
basti1302
force-pushed
the
meter-provider-merge-environment-resource-information
branch
from
7e7ebbe to
2d5dcda
Compare
dmathieu
reviewed
Sep 5, 2024
basti1302
force-pushed
the
meter-provider-merge-environment-resource-information
branch
from
ba7a47a to
649d3b2
Compare
dmathieu
reviewed
Sep 6, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
basti1302
force-pushed
the
meter-provider-merge-environment-resource-information
branch
from
e93b148 to
cdee9c9
Compare
pellared
reviewed
Sep 6, 2024
pellared
approved these changes
Sep 6, 2024
dmathieu
approved these changes
Sep 6, 2024
basti1302
deleted the
meter-provider-merge-environment-resource-information
branch
XSAM
added a commit
that referenced
this pull request
Sep 10, 2024
### Added - Support `OTEL_EXPORTER_OTLP_LOGS_INSECURE` and `OTEL_EXPORTER_OTLP_INSECURE` environments in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#5739) - The `WithResource` option for `NewMeterProvider` now merges the provided resources with the ones from environment variables. (#5773) - The `WithResource` option for `NewLoggerProvider` now merges the provided resources with the ones from environment variables. (#5773) - Add UTF-8 support to `go.opentelemetry.io/otel/exporters/prometheus`. (#5755) ### Fixed - Fix memory leak in the global `MeterProvider` when identical instruments are repeatedly created. (#5754) - Fix panic instruments creation when setting meter provider. (#5758) - Fix panic on instruments creation when setting meter provider. (#5758) - Fix an issue where `SetMeterProvider` in `go.opentelemetry.io/otel` might miss the delegation for instruments and registries. (#5780) ### Removed - Drop support for [Go 1.21](https://go.dev/doc/go1.21). (#5736, #5740, #5800)
basti1302
added a commit
to dash0hq/dash0-operator
that referenced
this pull request
Sep 11, 2024
Remove merge with resource.Environment() now that open-telemetry/opentelemetry-go#5773 has been merged.
basti1302
added a commit
to dash0hq/dash0-operator
that referenced
this pull request
Sep 11, 2024
Remove merge with resource.Environment() now that open-telemetry/opentelemetry-go#5773 has been merged.
basti1302
added a commit
to dash0hq/dash0-operator
that referenced
this pull request
Sep 11, 2024
Remove merge with resource.Environment() now that open-telemetry/opentelemetry-go#5773 has been merged.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5764