Add close to fix CWE-404 #12908
Merged
Add close to fix CWE-404 #12908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing InputStream close to fix CWE-404
|
hi @sam9291! you can ignore the test-latest-deps failures, I don't think they're related to your PR |
|
Hi @trask thanks for the feedback, before merging, I'll just need someone with a more experience than me on the context to confirm that my change doesn't impact anything else, the fix was inspired by what was done in #1970. I don't have the proper setup to run this locally easily, I'm more familiar with .net and go, but trying to contribute where I can 😅 |
|
can you run |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, our security tool has detected 2 CWE-404
Add missing JarFile close to fix CWE-404
Add missing InputStream close to fix CWE-404