Add context customizer hook to Instrumenter API #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Sep 20, 2021
Comment on lines
22
to
23
| // TODO (trask) should we pass startNanos | ||
| // similar to https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/4155? |
There was a problem hiding this comment.
These are only needed to compute duration metrics -- and are sort of useless without endNanos, so I'd say we should leave them out for now.
|
|
||
| /** | ||
| * Context customizer method that is called during {@link Instrumenter#start(Context, Object)}, | ||
| * allowing customization * of the {@link Context} that is returned from that method. |
There was a problem hiding this comment.
Suggested change
| * allowing customization * of the {@link Context} that is returned from that method. | |
| * allowing customization of the {@link Context} that is returned from that method. |
anuraaga
approved these changes
Sep 21, 2021
laurit
approved these changes
Sep 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #4102 (comment)
The first commit is the Instrumenter API changes only.
The other commits apply this to tomcat, jetty and servlet instrumentation to see what it looks like / if it's worth using it directly inside of instrumentation or if it should only be exposed as a customization hook for users of the instrumentation.