Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Intern db info #4263

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Intern db info #4263

merged 1 commit into from
Oct 4, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 1, 2021

Most applications should be using a connection pool that has a limited number of connections. The connections returned from that pool should be wrapped in a way that code in

can unwrap them to the original connection that was returned from jdbc driver. If that is the case then we'll have a small number of DbInfo instances. If application does not use a connection pool or we are unable to unwrap connection to get the original one that already has DbInfo attached we'll end up with a large number of DbInfo instances which all contain the same data. I have a heap dump that has a bit under a million DbInfo instances consuming slightly less than 500mb.

@trask trask merged commit 95651a4 into open-telemetry:main Oct 4, 2021
@laurit laurit deleted the intern-dbinfo branch July 6, 2023 17:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants