Test captured HTTP headers - HTTP server tests, part 1 #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
…hrown NPE on getHeaders())
trask
approved these changes
Oct 7, 2021
| testLibrary("io.undertow:undertow-servlet:1.0.0.Final") | ||
| testLibrary("io.undertow:undertow-servlet:1.4.28.Final") |
There was a problem hiding this comment.
Undertow 1.0 had a bug where it thrown NPE on getHeaders()
😱
There was a problem hiding this comment.
public Collection<String> getHeaders(String name) {
return new ArrayList(this.exchange.getResponseHeaders().get(name));
}Guess what happens when this.exchange.getResponseHeaders() returns null because there are no headers in the response yet 🙈
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new test case in
HttpServerTestjust for testing the captured headers; this test is enabled in some Spring boot test (javaagent instrumentation) and Restlet (library instrumentation). I'll enable it in all other tests in the next PR.