Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

style: format README #1065

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

naseemkullah
Copy link
Member

@naseemkullah naseemkullah commented May 16, 2020

Just fixing up spacing. 🤷‍♂️

(Tables were formatted automatically. Empty lines were added/removed manually.)

Signed-off-by: Naseem <naseem@transit.app>
@codecov-io
Copy link

codecov-io commented May 16, 2020

Codecov Report

Merging #1065 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         213      213           
  Lines        8950     8950           
  Branches      806      806           
=======================================
  Hits         8514     8514           
  Misses        436      436           

@mayurkale22 mayurkale22 added the document Documentation-related label May 18, 2020
@mayurkale22 mayurkale22 merged commit 4056f36 into open-telemetry:master May 18, 2020
@naseemkullah naseemkullah deleted the format-readme branch April 9, 2021 18:19
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: remove node 8 and 10 from CI

* chore: update engines

* chore: add node 18 to CI

* fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket

* test: reference the actual error message

* test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality

In the CI there will be 3 instances of the API installed(relative to the repo root):

- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`,
- `./node_modules/@opentelemetry/api`,
- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`.

* chore: remove support for node@12 updating the engines

* chore: remove test runs on node@12

* test(resource-detector-alibaba-cloud): revert change, disable tests for node@18

* fix: turn fastify tests off for node@18
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* chore: remove node 8 and 10 from CI

* chore: update engines

* chore: add node 18 to CI

* fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket

* test: reference the actual error message

* test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality

In the CI there will be 3 instances of the API installed(relative to the repo root):

- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`,
- `./node_modules/@opentelemetry/api`,
- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`.

* chore: remove support for node@12 updating the engines

* chore: remove test runs on node@12

* test(resource-detector-alibaba-cloud): revert change, disable tests for node@18

* fix: turn fastify tests off for node@18
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
* chore: remove node 8 and 10 from CI

* chore: update engines

* chore: add node 18 to CI

* fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket

* test: reference the actual error message

* test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality

In the CI there will be 3 instances of the API installed(relative to the repo root):

- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`,
- `./node_modules/@opentelemetry/api`,
- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`.

* chore: remove support for node@12 updating the engines

* chore: remove test runs on node@12

* test(resource-detector-alibaba-cloud): revert change, disable tests for node@18

* fix: turn fastify tests off for node@18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants