Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: fix markdown linting and add npm script #1217

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 18, 2020

Unblocks some open PRs including #1216 which are failing the lint check.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1217   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         122      122           
  Lines        3533     3533           
  Branches      714      714           
=======================================
  Hits         3262     3262           
  Misses        271      271           

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran into this after updating #1171.

@dyladan
Copy link
Member Author

dyladan commented Jun 18, 2020

I just ran into this after updating #1171.

All PRs will run into this

@dyladan dyladan merged commit f9f5df5 into open-telemetry:master Jun 18, 2020
@dyladan dyladan deleted the markdown-lint-fix branch June 18, 2020 20:44
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants