Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: replacing console with diag #2006

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented Mar 10, 2021

No description provided.

@obecny obecny added the enhancement New feature or request label Mar 10, 2021
@obecny obecny self-assigned this Mar 10, 2021
@obecny obecny added bug Something isn't working and removed enhancement New feature or request labels Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2006 (b08c6a0) into main (60c04b1) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   92.92%   92.91%   -0.02%     
==========================================
  Files         152      152              
  Lines        5923     5924       +1     
  Branches     1245     1245              
==========================================
  Hits         5504     5504              
- Misses        419      420       +1     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-node/src/sdk.ts 76.81% <50.00%> (+0.34%) ⬆️
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@Flarna
Copy link
Member

Flarna commented Mar 10, 2021

Maybe we should add "no-console": "error" to our eslint config?

@obecny
Copy link
Member Author

obecny commented Mar 10, 2021

no-console": "error" to our eslint config

#2007

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants