Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: adding sufix propagator to http baggage and http trace context #2149

Merged
merged 7 commits into from
Apr 30, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 22, 2021

Fixes #2142

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2149 (bcc4df5) into main (c4341c3) will increase coverage by 0.06%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
+ Coverage   92.75%   92.82%   +0.06%     
==========================================
  Files         140      140              
  Lines        4997     5002       +5     
  Branches     1028     1029       +1     
==========================================
+ Hits         4635     4643       +8     
+ Misses        362      359       -3     
Impacted Files Coverage Δ
...es/opentelemetry-core/src/propagation/composite.ts 100.00% <ø> (ø)
...ackages/opentelemetry-shim-opentracing/src/shim.ts 89.68% <77.77%> (+2.07%) ⬆️
...e/src/baggage/propagation/HttpBaggagePropagator.ts 98.24% <100.00%> (ø)
...metry-core/src/trace/HttpTraceContextPropagator.ts 100.00% <100.00%> (ø)
...s/opentelemetry-tracing/src/BasicTracerProvider.ts 96.61% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@obecny obecny self-assigned this Apr 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding the Propagator suffix to tracecontext/baggage propagators
4 participants